> void CMyApp::A_Funtion()
> {
> CString A = "Hello A";
> m_struct.A = new char[ A.GetLength() +1 ];
> strcpy( m_struct.A, A );
> m_struct.A[ A.GetLength() ] = '\0';

> CString B = "Hello B";
> m_struct.B = new char[ B.GetLength() +1 ];
> strcpy( m_struct.B, B );
> m_struct.B[ B.GetLength() ] = '\0';
> }

> void CMyApp::MainLoop()
> {
>     m_struct = new CMyStruct;
>     A_Function();
>     //....
>     // Do some more work

>     delete m_struct.A;
>     delete m_struct.B;
>     delete m_struct;
> }

> I am assuming that my CStrings will never be empty.
> Now my problem is that delete B give me an assert, (and a Crash).
> Why, am I not doing my 'new' properly?

> How should it be done? Is there a better way?

> Many thanks
> --
> FFMG
> Please remove _NOSPAM in email address for reply.

>void CMyApp::A_Funtion()
>{
>CString A = "Hello A";
>m_struct.A = new char[ A.GetLength() +1 ];
>strcpy( m_struct.A, A );
>m_struct.A[ A.GetLength() ] = '\0';

>CString B = "Hello B";
>m_struct.B = new char[ B.GetLength() +1 ];
>strcpy( m_struct.B, B );
>m_struct.B[ B.GetLength() ] = '\0';
>}

>    delete m_struct.A;
>    delete m_struct.B;
>    delete m_struct;
>}

>I am assuming that my CStrings will never be empty.
>Now my problem is that delete B give me an assert, (and a Crash).
>Why, am I not doing my 'new' properly?

> by copying from the object instead of the "string IN the object" you're
> probably copying too much since strcpy copies until it reaches a NULL.  My
> guess is that between your A copy and B copy you trash something sensative
> that shows up when you delete...

> HTH
> wardo

> > Hi,
> > I have a program

> > void CMyApp::A_Funtion()
> > {
> > CString A = "Hello A";
> > m_struct.A = new char[ A.GetLength() +1 ];
> > strcpy( m_struct.A, A );
> > m_struct.A[ A.GetLength() ] = '\0';

> > CString B = "Hello B";
> > m_struct.B = new char[ B.GetLength() +1 ];
> > strcpy( m_struct.B, B );
> > m_struct.B[ B.GetLength() ] = '\0';
> > }

> > void CMyApp::MainLoop()
> > {
> >     m_struct = new CMyStruct;
> >     A_Function();
> >     //....
> >     // Do some more work

> >     delete m_struct.A;
> >     delete m_struct.B;
> >     delete m_struct;
> > }

> > I am assuming that my CStrings will never be empty.
> > Now my problem is that delete B give me an assert, (and a Crash).
> > Why, am I not doing my 'new' properly?

> > How should it be done? Is there a better way?

> > Many thanks
> > --
> > FFMG
> > Please remove _NOSPAM in email address for reply.

> by copying from the object instead of the "string IN the object" you're
> probably copying too much since strcpy copies until it reaches a NULL.  My
> guess is that between your A copy and B copy you trash something sensative
> that shows up when you delete...

> HTH
> wardo

> > Hi,
> > I have a program

> > void CMyApp::A_Funtion()
> > {
> > CString A = "Hello A";
> > m_struct.A = new char[ A.GetLength() +1 ];
> > strcpy( m_struct.A, A );
> > m_struct.A[ A.GetLength() ] = '\0';

> > CString B = "Hello B";
> > m_struct.B = new char[ B.GetLength() +1 ];
> > strcpy( m_struct.B, B );
> > m_struct.B[ B.GetLength() ] = '\0';
> > }

> > void CMyApp::MainLoop()
> > {
> >     m_struct = new CMyStruct;
> >     A_Function();
> >     //....
> >     // Do some more work

> >     delete m_struct.A;
> >     delete m_struct.B;
> >     delete m_struct;
> > }

> > I am assuming that my CStrings will never be empty.
> > Now my problem is that delete B give me an assert, (and a Crash).
> > Why, am I not doing my 'new' properly?

> > How should it be done? Is there a better way?

> > Many thanks
> > --
> > FFMG
> > Please remove _NOSPAM in email address for reply.

> I just need to clarify.
> first,  I am doing
>     delete [] m_struct->A;
>     delete [] m_struct->B;
> not
>     delete m_struct.A;
>     delete m_struct.B;
> That was a very bad typo from my side.

> secondly I could put it in the destructor but the fact remains that I
cannot
> delete it.
> It always crashes, (delete [] m_struct->B is crashing).

> I don't know if this will help but the Assert message is

> File:dbgheap.c
> Line:1109

> Expression: _pFirstBlock == pHead

> I can use m_struct->B without any problems. Even if I put a break just
> before to the delete I can still see that the data is valid.
> I just can't see why it would be crashing.

> --
> FFMG
> Please remove _NOSPAM in email address for reply.


> > FFMG,
> >    you're trying to copy a string from a CString object pointer...
> > > strcpy( m_struct.A, A );
> >    instead of
> > > strcpy( m_struct.A, (LPCTSTR)A );
> > > strcpy( m_struct.B, (LPCTSTR)B );

> > by copying from the object instead of the "string IN the object" you're
> > probably copying too much since strcpy copies until it reaches a NULL.
My
> > guess is that between your A copy and B copy you trash something
sensative
> > that shows up when you delete...

> > HTH
> > wardo

> > > Hi,
> > > I have a program

> > > void CMyApp::A_Funtion()
> > > {
> > > CString A = "Hello A";
> > > m_struct.A = new char[ A.GetLength() +1 ];
> > > strcpy( m_struct.A, A );
> > > m_struct.A[ A.GetLength() ] = '\0';

> > > CString B = "Hello B";
> > > m_struct.B = new char[ B.GetLength() +1 ];
> > > strcpy( m_struct.B, B );
> > > m_struct.B[ B.GetLength() ] = '\0';
> > > }

> > > void CMyApp::MainLoop()
> > > {
> > >     m_struct = new CMyStruct;
> > >     A_Function();
> > >     //....
> > >     // Do some more work

> > >     delete m_struct.A;
> > >     delete m_struct.B;
> > >     delete m_struct;
> > > }

> > > I am assuming that my CStrings will never be empty.
> > > Now my problem is that delete B give me an assert, (and a Crash).
> > > Why, am I not doing my 'new' properly?

> > > How should it be done? Is there a better way?

> > > Many thanks
> > > --
> > > FFMG
> > > Please remove _NOSPAM in email address for reply.

> > I don't know if this will help but the Assert message is

> > File:dbgheap.c
> > Line:1109

> > Expression: _pFirstBlock == pHead

> > I can use m_struct->B without any problems. Even if I put a break just
> > before to the delete I can still see that the data is valid.
> > I just can't see why it would be crashing.

> >FFMG,
> >   you're trying to copy a string from a CString object pointer...
> >> strcpy( m_struct.A, A );
> >   instead of
> >> strcpy( m_struct.A, (LPCTSTR)A );

> Due to CString::operatr LPCTSTR, the two are equivalent. You do need
> to cast when passing CStrings to printf and other variadic functions,
> but strcpy's second parameter is const char*, so the cast is
> superfluous for strcpy.

> --
> Doug Harrison [VC++ MVP]
> Eluent Software, LLC
> http://www.eluent.com
> Tools for Visual C++ and Windows

> void CMyApp::A_Funtion()
> {
> ZeroMemory( m_struct, sizeof( CMyStruct));
> CString A = "Hello A";
> m_struct->A = new char[ A.GetLength() +1 ];
> strcpy( m_struct->A, A );
> m_struct->A[ A.GetLength() ] = '\0';

> CString B = "Hello B";
> m_struct->B = new char[ B.GetLength() +1 ];
> strcpy( m_struct->B, B );
> m_struct->B[ B.GetLength() ] = '\0';
> }

> void CMyApp::MainLoop()
> {
>     m_struct = new CMyStruct;
>     A_Function();
>     //....
>     // Do some more work

>     delete [] m_struct->A;
>     delete [] m_struct->B;
>     delete m_struct;
> }

> The difference between this code and the actual code is the structure has
7
> members, (either int or LPSTR).

> --
> FFMG
> Please remove _NOSPAM in email address for reply.

> > > secondly I could put it in the destructor but the fact remains that I
> > cannot
> > > delete it.
> > > It always crashes, (delete [] m_struct->B is crashing).

> > > I don't know if this will help but the Assert message is

> > > File:dbgheap.c
> > > Line:1109

> > > Expression: _pFirstBlock == pHead

> > > I can use m_struct->B without any problems. Even if I put a break just
> > > before to the delete I can still see that the data is valid.
> > > I just can't see why it would be crashing.

> > Hi,
> > Here is the code again without the mistakes

> > void CMyApp::A_Funtion()
> > {
> > ZeroMemory( m_struct, sizeof( CMyStruct));
> > CString A = "Hello A";
> > m_struct->A = new char[ A.GetLength() +1 ];
> > strcpy( m_struct->A, A );
> > m_struct->A[ A.GetLength() ] = '\0';

> > CString B = "Hello B";
> > m_struct->B = new char[ B.GetLength() +1 ];
> > strcpy( m_struct->B, B );
> > m_struct->B[ B.GetLength() ] = '\0';
> > }

> > void CMyApp::MainLoop()
> > {
> >     m_struct = new CMyStruct;
> >     A_Function();
> >     //....
> >     // Do some more work

> >     delete [] m_struct->A;
> >     delete [] m_struct->B;
> >     delete m_struct;
> > }

> > The difference between this code and the actual code is the structure
has
> 7
> > members, (either int or LPSTR).

> > --
> > FFMG
> > Please remove _NOSPAM in email address for reply.

> > > > secondly I could put it in the destructor but the fact remains that
I
> > > cannot
> > > > delete it.
> > > > It always crashes, (delete [] m_struct->B is crashing).

> > > > I don't know if this will help but the Assert message is

> > > > File:dbgheap.c
> > > > Line:1109

> > > > Expression: _pFirstBlock == pHead

> > > > I can use m_struct->B without any problems. Even if I put a break
just
> > > > before to the delete I can still see that the data is valid.
> > > > I just can't see why it would be crashing.

> [ code to copy a couple of strings into a struct elided ]

> > void CMyApp::MainLoop()
> > {
> >     m_struct = new CMyStruct;
> >     A_Function();

> Nothing you've shown us looks like it should be causing a problem.
> The declaration of CMyStruct _might_ have some relevance, though it's
> a bit hard to say.  We're probably not going to be able to provide a
> lot of real help until/unless you do your part: cut your code down to
> the minimal that still displays the problem, and then post it so we
> can actually see the problem.

> >     //....
> >     // Do some more work

> Based on what you've posted, the "more work" may easily be where
> you're causing the problem, but it's impossible to really guess
> without knowing that that is.  If you corrupt one of your pointers
> (for one example) you can end up using data that doesn't really
> belong to you.

> > How should it be done? Is there a better way?

> Probably.  It's a bit hard to say since you haven't showed up what
> you're doing with things, but offhand the code looks like almost the
> antithesis of object oriented -- you have a CMyStruct, but it's code
> outside of CMyStruct that's manipulating its contents.  There's a
> pretty fair chance that most (perhaps all) of the code you've shown
> us should really be member functions of CMyStruct (perhaps suitably
> renamed to reflect the fact that it's not just dumb data.  Based on
> what you've shown so far, I'd envision something like this:

> class MyData {
> CString A;
> CString B;
> public:
>   MyData(CString init_A, CString init_b)
> : A(init_A), B(init_B)
> {}

> void DoWork() {
> // Do some more work
> // converting CStrings to char *'s ONLY as needed.
> }
> };

> void CMyApp::MainLoop() {
> MyData data("Hello_A", "Hello_B");

> data.DoWork();
> }

> --
>     Later,
>     Jerry.

> The Universe is a figment of its own imagination.

>Last but not least the function that I am calling is in a separate DLL. But
>it is a simple function call to a DLL,